Repository navigation
Carry per-root-Turn settings over the Runtime protocol - #918
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Add proto.TurnSettings (model, reasoning effort, service tier, review) to the prepare configuration, moved out of agent_options and ExecutionControls. The Executor identity ignores it; the Runtime hands each Turn's settings to StartTurn. harnessconfig gains Reviews and ValidateTurnSettings, and Prepare takes the model. Protocol version 0.24.0. No behavior change.
A retained Executor that accepted a different turn would have run the prepared settings silently. Review support has no sender yet, so it waits for the change that sends it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change carries the official per-root-Turn settings over the Core–Runtime and Runtime–Harness protocols, ahead of the Session
agentupdate andreview(Agents API pin 3.45.0). Behavior does not change: every Harness receives the same values as before.Protocol
PromptRequestPayload.Turnis a newproto.TurnSettingsholdingmodel,reasoning_effortandservice_tier. The fields moved there from their old places, so none of them exists twice:modelis no longer inagent_options;ExecutionControls.proto.Versionis now 0.24.0.Turnstays part of the Executor's identity, so a retained Executor with different settings is still aconfiguration_conflict.StartTurn(ctx, runID, turn, input, out)receives the Turn's settings, which equal the prepared ones. The change that applies them natively also relaxes the identity, for Harnesses that declare it.Turn, and validation enforces it.harnessconfiggetsPrepare(model, options)andValidateTurnSettings.ValidateTurnSettingstakes over the effort and tier checks fromValidateExecutionControls. As a result, when a request has several unsupported values, the 400 message may name a different field first.Turnfrom the Session snapshot, and the adapters read model, effort and tier from it at startup.docs/runtime-protocol.md,harness-onboarding.mdandexecution-tools.md. The wire scenario checks thatStartTurnreceivesTurn.Verification
go vetpasses.go testpasses for./internal/...,./apps/daemon/...and Coreexecution.make check-runtime-contractandmake check-harness-catalogpass.check-translationspasses.turn.model, including after suspension;Turnfrom the snapshot;Turnto its native config and rejects undeclared values.