fix: surface bridge.set_seq failures instead of swallowing them#136
fix: surface bridge.set_seq failures instead of swallowing them#136Mingye-Lu wants to merge 1 commit into
Conversation
increment_seq is called by nearly every mutating tool to tag the bridge's observations for since/until temporal windowing, but its bridge.set_seq() call result was discarded with `let _ = ...`. A failure here silently desyncs the bridge's tagging from CrawlState's seq counter, corrupting since/until windowing used by network_activity, websocket_activity, and page_logs, with no diagnostic. A set_seq failure is still treated as non-fatal to the calling tool (consistent with existing non-fatal warning patterns elsewhere in the crate, e.g. implementation/lifecycle.rs), but it is now surfaced via eprintln! instead of silently discarded. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review — retrying, previous review attempt hit the Codex usage-limit error. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
increment_seq(called by nearly every mutating tool) discardedbridge.set_seq()'s result withlet _ = .... A failure here silently desyncs the bridge's temporal tagging fromCrawlState's seq counter, corruptingsince/untilwindowing used bynetwork_activity,websocket_activity, andpage_logs, with zero diagnostic.implementation/lifecycle.rs), but now surface it viaeprintln!instead of silently discarding it.fail_set_seqtoggle to the sharedObservationMockBackendtest double so this path is exercisable in tests.Test plan
cargo fmt --package agentcargo test -p agent(629 passed, including new regression testincrement_seq_still_returns_action_seq_when_bridge_set_seq_fails)cargo clippy -p agent --all-targets -- -D warnings(clean)