[codex] integrate upstream-safe stable surface#6
Merged
Conversation
… routes + replan on toggle/drag-release; router(oxdraw): drop CLASS obstacles, only edge-edge crossings; anchors: use enode yellow port for start to keep dot consistent across styles
…e PlantEdge consumes Smooth; re-run on LMB release
…set+stub, pairing, detours); trim endpoints; ignore node volume (temporary) - Remove Grid/A* code and params - Update call sites to unit arg () - Keep inner-anchor (yellow port) stable when trimming
Expand parser and lowering coverage for the t224 transpiler line, add batch and sweep CLIs, and make declaration-aware eggcc validation green across both eggcc trees. Reference: #257 Reference: #252 Reference: #254 Reference: #255
…s merge of origin/fix/normalize-qz-ty-names\ninto the local fix/normalize-qz-ty-names worktree while preserving\nthe staged conflict resolutions and example additions.\n
Support relation-heavy transfer scenarios with a focused regression and example while preserving the existing local worktree state. - fix relation PatVars metadata iteration for nested fields - add transfer story smoke coverage in src/test.rs - keep related RuleCtx/constraint support updates together with the test
Port the non-fork-dependent parts of the experimental branch onto the stable integration branch. This includes relation/function query helpers, display and typst metadata, action sample recorder support, pseudo-singleton examples, benchmark/report helper cleanup, and the stable-side gating/fallbacks needed to keep upstream egglog green by default. Fork-only proof, artifact, persisted-snapshot, timestamp-constraint, and EBoost schema/raw-introspection paths are explicitly gated or downgraded so the default stable surface compiles and tests cleanly against upstream egglog.
Contributor
Merging this PR will create unknown performance changes
Performance Changes
Comparing Footnotes
|
Remove the remaining warning output from the upstream-safe stable integration branch. This cleans macro-side unused items, trims or gates proof-only helper remnants, and adds minimal support/example/test-local lint annotations where those modules are intentionally partial in the stable surface. Verified with fresh runs of cargo test and cargo build --examples.
Delete genuinely unused helpers, narrow multi-target support imports to local warning boundaries, and gate test-only utilities behind cfg(test) instead of hiding them with blanket dead_code suppressions. Verified with RUSTFLAGS='-Dwarnings' cargo test and RUSTFLAGS='-Dwarnings' cargo build --examples.
Replace machine-specific /Users/mineralsteins paths in generated comments and tests with repo-relative or dynamically discovered fixture paths. This keeps the PR reviewable on other machines and makes the transpiler fixture tests locate sibling upstream checkouts without hard-coding one local directory layout. Verified with cargo test -p eggplant-transpiler and the affected path-based tests.
Remove the temporary superpowers planning/review notes from the stable PR branch so the pull request only carries product-facing code and docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR integrates the non-fork-dependent parts of the experimental branch onto
stablewhile keeping the default branch green against upstreamegglog.The merged surface includes:
What Was Blocking Stable
experimentalhad accumulated multiple features that assumed our custom egglog fork:egglog::FunctionIdThose assumptions prevented a direct move onto upstream
egglogand made the default stable surface fail to compile or test cleanly.What Changed
The stable integration branch now does three things:
It ports the upstream-safe feature groups from
experimental.The query sugar, metadata support, recorder support, pseudo-singleton examples, and benchmark/example cleanup are all carried over.
It de-forks the runtime surface.
The rule/runtime wrapper now uses upstream-compatible
rust_rulepaths by default, no longer requires fork-only rule metadata APIs, and no longer exposes fork-specific cached function IDs.It explicitly fences off fork-only behavior.
Proof, persisted-snapshot, artifact/schema, timestamp-filter attachment, and EBoost-specific paths are either feature-gated behind
fork-egglogor downgraded to stable-safe fallback examples/stubs so the default branch does not pretend to support functionality that upstreamegglogcannot provide.User-Facing Effect
For stable reviewers and users, the default branch behavior is now coherent:
cargo testpasses on the stable integration branch using upstreamegglogcargo build --examplespassesValidation
Fresh verification run on this branch:
cargo testcargo build --examplescargo run --example constant_prop_pseudo_singletoncargo run --example constant_prop_pseudo_singleton_asynccargo run --example relation_transfer_storycargo run --example timestamp_filterScope Boundaries
This PR intentionally does not make the following default-stable features available:
Those remain explicitly separated so we can review a truthful stable surface instead of a partial port that still depends on the custom fork.