Choose modifying startRendering as the preferred approach#1332
Open
gabrielsanbrito wants to merge 2 commits into
Open
Choose modifying startRendering as the preferred approach#1332gabrielsanbrito wants to merge 2 commits into
gabrielsanbrito wants to merge 2 commits into
Conversation
Contributor
rahulsingh-msft
left a comment
rahulsingh-msft
left a comment
There was a problem hiding this comment.
Thanks for updating this! I made some suggestions to improve readability.
Contributor
Author
|
@rahulsingh-msft, thanks for the feedback! Everything should be addressed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the progressive OfflineAudioContext explainer to reflect the latest discussions that happened in the Audio WG (discussion thread here). The main outcome is that now the preferred approach is to modify the behavior of
OfflineAudioContext.startRenderingin a backward-compatible manner so that it now renders audio in chunks by default.