Replace nested promote/lift switches with std::variant dispatch#64
Open
d-torrance wants to merge 1 commit into
Open
Replace nested promote/lift switches with std::variant dispatch#64d-torrance wants to merge 1 commit into
d-torrance wants to merge 1 commit into
Conversation
Replaces the ~130-line nested switch in ConcreteRing::promote and the ~100-line nested switch in ConcreteRing::lift with a RingVariant + toVariant helper and a two-argument std::visit lambda that calls mypromote/mylift directly on the unwrapped concrete ring references. The old lift switch had three latent bugs now fixed automatically: - ring_RRi and ring_CCi source arms were missing (those mylift specializations in aring-translate.hpp were unreachable) - The ring_CC→ring_CCC and ring_CCC→ring_CC lift template args were swapped Structural drift is now impossible: adding a new ring type requires only adding it to RingVariant and toVariant; the compiler enforces coverage. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #62
Replaces the ~130-line nested switch in ConcreteRing::promote and the ~100-line nested switch in ConcreteRing::lift with a RingVariant + toVariant helper and a two-argument std::visit lambda that calls mypromote/mylift directly on the unwrapped concrete ring references.
The old lift switch had three latent bugs now fixed automatically:
Structural drift is now impossible: adding a new ring type requires only adding it to RingVariant and toVariant; the compiler enforces coverage.
Cc: @haackett