review current changes#1
Open
Mycroft221 wants to merge 48 commits intocode_reviewfrom
Open
Conversation
…e ir beam strength on the fly
Hardware issue, ESD or something killed ir receivers??
Mycroft221
commented
Mar 3, 2024
| return 0; | ||
| } | ||
|
|
||
| bool melty::isBeaconSensed(bool currentReading) { |
Collaborator
Author
There was a problem hiding this comment.
A short comment describing the purpose of this function would be helpful here, as this function's purpose in unclear on its own. Something like "check if IR reading in any of the last IRLedDataSize melty::update() cycles is equal to lastIRLedReturnValue, if so, return lastIRLedReturnValue, otherwise, negate lastIRLedReturnValue and return lastIRLedReturnValue"
Mew463
reviewed
Mar 3, 2024
Mycroft221
commented
Mar 3, 2024
|
|
||
| void melty::update() { | ||
| bool curSeenIRLed; | ||
| if (useTopIr) |
Collaborator
Author
There was a problem hiding this comment.
Recommend always using curly braces for readability https://google.github.io/styleguide/cppguide.html#Formatting_Looping_Branching
Still need to add in accelerometer and not have to fully rely on seeing the IR beacon every rotation
…ss of IR led tracking
…re its because of low speced battery
…pin oppposite direction
…n wave translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.