feat: add withholding tax & profit-change tracking - #4
Merged
Conversation
Implements withholding-tax handling and month-over-month profit change tracking. Engine: apply withholding tax on positive gross monthly returns, deduct from nominal value, accumulate totalWithholdingTax, compute nominal/real profit deltas and include them (rounded to 2 decimals). UI: add withholding tax input to PortfolioForm and new table columns (Nominal Δ, Real Δ, Withholding Tax) with icons/colors; adjust empty-state colspan. Export: include new columns and total withholding tax in CSV. Types/store: add withholdingTax fields and default param. Tests: add engine test for tax/profit-change behavior. Bump app version to 1.2.0.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements withholding-tax handling and month-over-month profit change tracking. Engine: apply withholding tax on positive gross monthly returns, deduct from nominal value, accumulate totalWithholdingTax, compute nominal/real profit deltas and include them (rounded to 2 decimals). UI: add withholding tax input to PortfolioForm and new table columns (Nominal Δ, Real Δ, Withholding Tax) with icons/colors; adjust empty-state colspan. Export: include new columns and total withholding tax in CSV. Types/store: add withholdingTax fields and default param. Tests: add engine test for tax/profit-change behavior. Bump app version to 1.2.0.