fix: handle non-url origins#137
Closed
0xEdouardEth wants to merge 1 commit into
Closed
Conversation
e88b029 to
5a1e6d5
Compare
5a1e6d5 to
1548105
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR updates the Stellar Snap confirmation origin helpers to handle non-URL origins such as the stable
wallet-connectorigin used by MetaMask Mobile WalletConnect multichain requests.Valid HTTP(S) URL origins continue to be displayed as hostnames. Known non-URL origins are displayed with friendly labels, currently
MetaMaskandWalletConnect. Unknown invalid origins, including WalletConnect channel IDs, now format to an empty string so confirmation UI can avoid showing meaningless identifiers.Tests were added for known origins, URL origins, non-http URLs, WalletConnect channel IDs, invalid origin strings, and the existing confirmation utility behavior.
References
Checklist
Validation
Result: 1 test suite passed, 23 tests passed.
Result: passed.