fix: escape regex metacharacters when building changelog link pattern#337
Open
adonesky1 wants to merge 1 commit into
Open
fix: escape regex metacharacters when building changelog link pattern#337adonesky1 wants to merge 1 commit into
adonesky1 wants to merge 1 commit into
Conversation
Resolves CodeQL js/incomplete-sanitization (high) in bump-dependent-playgrounds.ts. packageName was interpolated into a dynamically-constructed RegExp after escaping only forward slashes, leaving backslashes and other regex metacharacters unescaped. Replace the ad-hoc .replace with a proper escapeRegExp helper.
wenfix
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves CodeQL
js/incomplete-sanitization(high) inscripts/bump-dependent-playgrounds.ts.packageNameis interpolated into a dynamically-constructedRegExp, but it was only run through.replace(/\//gu, '\\/')— which escapes forward slashes and leaves backslashes and other regex metacharacters unescaped. This replaces the ad-hoc escape with a properescapeRegExphelper.This is a pre-existing issue on
main(independent of the repo rename in #267). Splitting it out into its own PR so the rename PR stays scoped to the rename.Changes
escapeRegExp(value)helper that escapes all regex metacharacters.packageNamewhen building the[Unreleased]link pattern.Behavior is unchanged for real package names (e.g.
@metamask/analytics), which contain no regex metacharacters.Notes
eslintpasses (verified via the pre-commit hook).