Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/validate/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"async-mutex": "^0.5.0",
"chalk": "^5.0.1",
"debug": "^4.3.4",
"glob": "^8.0.3",
"glob": "^9.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glob v9 upgrade breaks promisify-based usage pattern

High Severity

The glob dependency is being upgraded from v8 to v9, which is a breaking change. Glob v9 switched from a callback-based API to a native Promise-based API. The existing code in tools/validate/src/main.ts uses promisify(glob) which works with glob v8's callback API, but will not work correctly with glob v9. When promisify is called on an already-async function, the resulting wrapper never resolves because the callback is never invoked. This will cause the validation tool to hang or fail entirely.

Fix in Cursor Fix in Web

"is-valid-path": "^0.1.1",
"remark-frontmatter": "^4.0.1",
"remark-gfm": "^3.0.1",
Expand Down
40 changes: 23 additions & 17 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -499,9 +499,9 @@ __metadata:
linkType: hard

"diff@npm:^5.0.0":
version: 5.1.0
resolution: "diff@npm:5.1.0"
checksum: 10/f4557032a98b2967fe27b1a91dfcf8ebb6b9a24b1afe616b5c2312465100b861e9b8d4da374be535f2d6b967ce2f53826d7f6edc2a0d32b2ab55abc96acc2f9d
version: 5.2.0
resolution: "diff@npm:5.2.0"
checksum: 10/01b7b440f83a997350a988e9d2f558366c0f90f15be19f4aa7f1bb3109a4e153dfc3b9fbf78e14ea725717017407eeaa2271e3896374a0181e8f52445740846d
languageName: node
linkType: hard

Expand Down Expand Up @@ -672,16 +672,15 @@ __metadata:
languageName: node
linkType: hard

"glob@npm:^8.0.3":
version: 8.0.3
resolution: "glob@npm:8.0.3"
"glob@npm:^9.0.0":
version: 9.3.5
resolution: "glob@npm:9.3.5"
dependencies:
fs.realpath: "npm:^1.0.0"
inflight: "npm:^1.0.4"
inherits: "npm:2"
minimatch: "npm:^5.0.1"
once: "npm:^1.3.0"
checksum: 10/cd002c04010ffddba426376c3046466b923b5450f89a434e6a9df6bfec369a4e907afc436303d7fbc34366dcf37056dcc3bec41e41ce983ed8d78b6035ecc317
minimatch: "npm:^8.0.2"
minipass: "npm:^4.2.4"
path-scurry: "npm:^1.6.1"
checksum: 10/e5fa8a58adf53525bca42d82a1fad9e6800032b7e4d372209b80cfdca524dd9a7dbe7d01a92d7ed20d89c572457f12c250092bc8817cb4f1c63efefdf9b658c0
languageName: node
linkType: hard

Expand Down Expand Up @@ -1452,12 +1451,12 @@ __metadata:
languageName: node
linkType: hard

"minimatch@npm:^5.0.1":
version: 5.1.0
resolution: "minimatch@npm:5.1.0"
"minimatch@npm:^8.0.2":
version: 8.0.4
resolution: "minimatch@npm:8.0.4"
dependencies:
brace-expansion: "npm:^2.0.1"
checksum: 10/3bcc271af1e5e95260fb9acd859628db9567a27ff1fe45b42fcf9b37f17dddbc5a23a614108755a6e076a5109969cabdc0b266ae6929fab12e679ec0f07f65ec
checksum: 10/aef05598ee565e1013bc8a10f53410ac681561f901c1a084b8ecfd016c9ed919f58f4bbd5b63e05643189dfb26e8106a84f0e1ff12e4a263aa37e1cae7ce9828
languageName: node
linkType: hard

Expand Down Expand Up @@ -1530,6 +1529,13 @@ __metadata:
languageName: node
linkType: hard

"minipass@npm:^4.2.4":
version: 4.2.8
resolution: "minipass@npm:4.2.8"
checksum: 10/e148eb6dcb85c980234cad889139ef8ddf9d5bdac534f4f0268446c8792dd4c74f4502479be48de3c1cce2f6450f6da4d0d4a86405a8a12be04c1c36b339569a
languageName: node
linkType: hard

"minipass@npm:^5.0.0":
version: 5.0.0
resolution: "minipass@npm:5.0.0"
Expand Down Expand Up @@ -1721,7 +1727,7 @@ __metadata:
languageName: node
linkType: hard

"path-scurry@npm:^1.11.1":
"path-scurry@npm:^1.11.1, path-scurry@npm:^1.6.1":
version: 1.11.1
resolution: "path-scurry@npm:1.11.1"
dependencies:
Expand Down Expand Up @@ -2388,7 +2394,7 @@ __metadata:
async-mutex: "npm:^0.5.0"
chalk: "npm:^5.0.1"
debug: "npm:^4.3.4"
glob: "npm:^8.0.3"
glob: "npm:^9.0.0"
is-valid-path: "npm:^0.1.1"
mdast: "npm:^3.0.0"
remark-frontmatter: "npm:^4.0.1"
Expand Down