SIP-36: enabling eth_sendTransaction from within Snaps#180
Open
smilingkylan wants to merge 2 commits intomainfrom
Open
SIP-36: enabling eth_sendTransaction from within Snaps#180smilingkylan wants to merge 2 commits intomainfrom
smilingkylan wants to merge 2 commits intomainfrom
Conversation
|
|
||
| if (!renderFn) return; | ||
| await ethereum.request({ | ||
| method: "eth_sendTransaction", // <---------- |
Member
There was a problem hiding this comment.
The eth_sendTransaction API is now available using endowment:multichain-provider. Perhaps that removes the need for this SIP?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this task is to allow Snap developers to utilize the
eth_sendTransactionmethod on the Ethereum provider to generate new transactions when necessary.For the record I'm not 100% certain the specifics of which ETH JSON RPC call needs to be and in what manner, but the objective is to allow a Snap to present newly-created transactions to the user for signing.
Note
Adds draft SIP-36 specifying a new permission to let Snaps send transactions via
eth_sendTransaction, with example usage and considerations.SIPS/sip-36.mdproposing Snap-initiated transactions.endowment:eth_sendTransaction(alongsideendowment:ethereum-provider).onTransactionflow usingethereum.request({ method: "eth_sendTransaction", ... })and UI with@metamask/snaps-sdk/jsx.Written by Cursor Bugbot for commit 4db720c. This will update automatically on new commits. Configure here.