Add SIP-24: WebSocket connections for Keyring Snaps#143
Open
tmpfs wants to merge 2 commits intoMetaMask:mainfrom
Open
Add SIP-24: WebSocket connections for Keyring Snaps#143tmpfs wants to merge 2 commits intoMetaMask:mainfrom
tmpfs wants to merge 2 commits intoMetaMask:mainfrom
Conversation
The allowedOrigins for the endowment:keyring permission specifies which snap origins can connect to the keyring snap and this SIP is to allow outbound access from the snap to external resources so is better placed in endowment:network-access.
Contributor
Author
|
@Montoya, is it possible to take a look at this please? |
Contributor
|
@tmpfs Thank you for the proposal, but for now it is not possible to evaluate this until we determine how to architect the underlying websockets functionality |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.