Open
Conversation
Added Draft implementation of sip-13: Intercept connections to Wallet
Beefed up SIPP-13.md with some more explanations.
Improved typing in the API
Added types to method signature
Improved typing of method signature
Mrtenz
reviewed
Oct 9, 2023
Member
There was a problem hiding this comment.
This is very interesting. What do you think of expanding the scope of onConnect to any connection requests? So a website asking for accounts, but also when installing Snaps, and so on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to create a SIP for a snap that allows for the following:
(i) Intercept the connection to the wallet
(ii) Make a call to an external API to get feedback on the wallet address
(iii) If the feedback is negative block the connection to the wallet with a suitable warning message.