Skip to content

458 mesh for mesh tools - #459

Draft
Joerg Henrichs (hiker) wants to merge 130 commits into
MetOffice:mainfrom
hiker:458_mesh_for_mesh_tools
Draft

458 mesh for mesh tools#459
Joerg Henrichs (hiker) wants to merge 130 commits into
MetOffice:mainfrom
hiker:458_mesh_for_mesh_tools

Conversation

@hiker

Copy link
Copy Markdown
Contributor

This adds a simple build script for the mesh tools. It needs #442 to be merged in first.

Sci/Tech Reviewer:
Code Reviewer:

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

I have run the two included examples in the mesh_tools directory.

trac.log

Security Considerations

  • I have reviewed my changes for potential security issues
  • [N/A] Sensitive data is properly handled (if applicable)
  • [N/A] Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • [N/A] Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • [N/A] Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • [N/A] Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • [N/A] If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the HPC Optimisation Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

Joerg Henrichs (hiker) and others added 30 commits January 23, 2026 17:40
Joerg Henrichs (hiker) and others added 24 commits June 10, 2026 12:47
…be required for lfric_apps. Minor code updates.
@hiker
Joerg Henrichs (hiker) marked this pull request as draft September 1, 2026 04:39
@github-actions github-actions Bot added the cla-modified The CLA has been modified as part of this PR - added by GA label Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

⚠️ Hello Joerg Henrichs (@hiker)!

Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR.

Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-modified The CLA has been modified as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants