Skip to content

Fixing YAXT index list related memory leaks in generation of redistribution map #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andrew Coughtrie (andrewcoughtrie) merged 7 commits into from
Aug 28, 2026
Merged

Fixing YAXT index list related memory leaks in generation of redistribution map #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
94c670b
Fixed some formatting and source of large memory leaks
DrTVockerodtMO Aug 17, 2026
4de4f3d
Signed CLA
DrTVockerodtMO Aug 17, 2026
a79c330
It seems the idx_lists are vestigial in this routine so they ought to…
DrTVockerodtMO Aug 18, 2026
6430963
Merge branch 'main' into mem_leak_idxlists
DrTVockerodtMO Aug 18, 2026
bdd4ba7
Merge branch 'main' into mem_leak_idxlists
DrTVockerodtMO Aug 21, 2026
4ef0590
Merge branch 'main' into mem_leak_idxlists
DrTVockerodtMO Aug 25, 2026
e2122a2
Merge branch 'main' into mem_leak_idxlists
DrTVockerodtMO Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,4 @@
| ukmo-juan-castillo | Juan M. Castillo | Met Office | 2026-03-24 |
| mcdalvi | Mohit Dalvi | Met Office | 2026-06-19 |
| cjohnson-pi | Christine Johnson | Met Office | 2026-06-29 |
| DrTVockerodtMO | Terence Vockerodt | Met Office | 2026-08-17 |
8 changes: 2 additions & 6 deletions infrastructure/source/utilities/halo_comms_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,17 +837,13 @@ function generate_redistribution_map(src_indices, tgt_indices, datatype, xmap) &
redist = 0
#else
type(xt_redist) :: redist
type(xt_idxlist) :: src_idxlist, tgt_idxlist
integer(i_def), allocatable :: src_offsets(:)
integer(i_def), allocatable :: tgt_offsets(:)
integer(i_def) :: i
integer(i_def) :: datatype_mpi_val

if( global_mpi%is_comm_set() )then
! create decomposition descriptors
src_idxlist = xt_idxvec_new( src_indices, size(src_indices) )
tgt_idxlist = xt_idxvec_new( tgt_indices, size(tgt_indices) )

allocate(src_offsets( size(src_indices) ))
allocate(tgt_offsets( size(tgt_indices) ))

Expand All @@ -860,7 +856,7 @@ function generate_redistribution_map(src_indices, tgt_indices, datatype, xmap) &
end do

datatype_mpi_val = datatype%get_datatype_mpi_val()
redist = xt_redist_p2p_off_new(xmap, src_offsets,tgt_offsets, datatype_mpi_val)
redist = xt_redist_p2p_off_new(xmap, src_offsets, tgt_offsets, datatype_mpi_val)

deallocate(src_offsets)
deallocate(tgt_offsets)
Expand Down Expand Up @@ -903,7 +899,7 @@ function generate_exchange_map(src_indices, tgt_indices) result(xmap)
! generate exchange map
comm = global_mpi%get_comm()
xmap = xt_xmap_dist_dir_new( src_idxlist, tgt_idxlist, &
comm%get_comm_mpi_val() )
comm%get_comm_mpi_val() )
call xt_idxlist_delete(tgt_idxlist)
call xt_idxlist_delete(src_idxlist)
else
Expand Down
Loading