Import of high order turbulence closure scheme

[Shusuke Nishimoto (mo-snishimoto)]

PR Summary

Sci/Tech Reviewer: Adrian Lock (@Adrian-Lock)
Code Reviewer: Matthew Hambley (@MatthewHambley)

This PR imports high order turbulence closure scheme (3DTE Mk1 scheme) in UM to LFRic.

Please see #46 for details, documentation and extra tests performed.

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Apps rose-stem suite
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - test_3dte_mk1/run1

Suite Information

Item	Value
Suite Name	test_3dte_mk1/run1
Suite User	shusuke.nishimoto
Workflow Start	2026-08-24T19:03:43
Groups Run	all

Dependency	Reference	Main Like
casim	MetOffice/casim@2026.07.1	True
jules	MetOffice/jules@2026.07.1	True
lfric_apps	mo-snishimoto/lfric_apps@3dte_mk1	False
lfric_core	MetOffice/lfric_core@2026.07.1	True
moci	MetOffice/moci@2026.07.1	True
SimSys_Scripts	MetOffice/SimSys_Scripts@2026.07.1	True
socrates	MetOffice/socrates@2026.07.1	True
socrates-spectral	MetOffice/socrates-spectral@2026.07.1	True
ukca	MetOffice/ukca@2026.07.1	True

Task Information

❌ failed tasks - 3

Task	State
check_lfric_atm_3dte-seuk_MG_azspice_gnu_fast-debug-32bit	failed
check_lfric_atm_3dte-seuk_MG_ex1a_cce_fast-debug-32bit	failed
check_lfric_coupled_nwp_gal9-C48_ex1a_cce_fast-debug-64bit	failed

✅ succeeded tasks - 1610

⌛ waiting tasks - 2

Task	State
housekeep_azspice	waiting
housekeep_ex1a	waiting

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[iboutle]

A few comments below. Thanks!

[github-actions]

⚠️ Hello Shusuke Nishimoto (@mo-snishimoto)!

Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR.

Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up.

[Shusuke Nishimoto (mo-snishimoto)]

Hi iboutle, Thank you for the careful check and comments.
I fixed my branch, following your comment.
I also confirmed this change doesn't affect KGOs.

[iboutle]

Thanks, looks good to me now. Just to note the KGO change for the coupled model should disappear when this is merged up to the head of main