fix l bgc heat - #153
Draft
Eleanor Burke (eleanorgb) wants to merge 5 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the biogeochemical soil heating option (l_bgc_heat) so it can be used in UM-JULES configurations and with the 1-layer soil carbon setup, primarily by aligning the respiration/heating logic with the soil-carbon layer dimension (dim_cslayer) and removing prior “standalone-only” gating.
Changes:
- Update
soil_htcbiogenic heating to usedim_cslayer(carbon-layer dimension) rather thannshyd(hydrology/soil moisture levels). - Remove UM-side unavailability checks and standalone rose-meta constraints/warnings that prevented enabling
l_bgc_heat. - Add a new entry to
CONTRIBUTORS.md.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/science/soil/soil_htc_jls_mod.F90 |
Switch biogenic heating loops/array shape to use dim_cslayer and add required module import/OpenMP shared var. |
src/control/um/check_unavailable_options_mod.F90 |
Remove the UM runtime message that previously rejected l_bgc_heat. |
src/control/shared/jules_soil_biogeochem_mod.F90 |
Relax configuration checks that previously required l_q10/l_layeredc for l_bgc_heat. |
rose-meta/jules-standalone/HEAD/rose-meta.conf |
Remove standalone metadata restriction and warning tied to UM and l_q10 when using l_bgc_heat. |
CONTRIBUTORS.md |
Add contributor entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Eleanor Burke (eleanorgb)
removed the request for review
from Noah Smith (noahdsmith)
August 28, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Updating l_bgc_heat to work with UM/and one layer soil carbon model
Sci/Tech Reviewer: Joe Clarke (@josephjclarke)
Code Reviewer:
https://github.com/MetOffice/um/pull/126
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
rose-meta/jules-sharedthen have you supplied a linked UM and LFRic Apps PR?UM only linked PR: https://github.com/MetOffice/um/pull/126
Testing
Im putting a series of changes in all of which I will protect with a rose stem test gong forwards
Test Suite Results - jules - l_bgc_heat/run2
Suite Information
Task Information
✅ succeeded tasks - 676
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
Approvals
Please request all relevant approvals. See the CodeOwners.txt file for section owners.
Technical
Scientific
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review