Skip to content

fix l bgc heat - #153

Draft
Eleanor Burke (eleanorgb) wants to merge 5 commits into
MetOffice:mainfrom
eleanorgb:126---fix-l_bgc_heat
Draft

fix l bgc heat#153
Eleanor Burke (eleanorgb) wants to merge 5 commits into
MetOffice:mainfrom
eleanorgb:126---fix-l_bgc_heat

Conversation

@eleanorgb

@eleanorgb Eleanor Burke (eleanorgb) commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Updating l_bgc_heat to work with UM/and one layer soil carbon model

Sci/Tech Reviewer: Joe Clarke (@josephjclarke)
Code Reviewer:

https://github.com/MetOffice/um/pull/126

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • If editing rose-meta/jules-shared then have you supplied a linked UM and LFRic Apps PR?

UM only linked PR: https://github.com/MetOffice/um/pull/126

Testing

  • I have tested this change locally, using the JULES rose-stem suite
  • If shared files have been modified, I have run the UM and LFRic Apps rose stem suites
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system tests, unit tests, etc.)

Im putting a series of changes in all of which I will protect with a rose stem test gong forwards

Test Suite Results - jules - l_bgc_heat/run2

Suite Information

Item Value
Suite Name l_bgc_heat/run2
Suite User eleanor.burke
Workflow Start 2026-08-28T12:12:09
Groups Run all
Dependency Reference Main Like
jules eleanorgb/jules@126---fix-l_bgc_heat False
SimSys_Scripts MetOffice/SimSys_Scripts@2026.07.1 True

Task Information

✅ succeeded tasks - 676

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

Approvals

Please request all relevant approvals. See the CodeOwners.txt file for section owners.

Technical

  • JULES Code Owner
  • OpenMP
  • River Routing
  • Rose Stem
  • Rose Metadata
  • Upgrade Macros

Scientific

  • Surface
  • Hydrology
  • Vegetation
  • Veg3 RED Demography
  • Biogeochemistry - approved by Eleanor Burke
  • Biogenic fluxes
  • Fire
  • Lakes
  • Evaluation
  • Imogen

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Aug 28, 2026
@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Aug 28, 2026
@eleanorgb Eleanor Burke (eleanorgb) changed the title 126 fix l bgc heat fix l bgc heat Aug 28, 2026
@eleanorgb Eleanor Burke (eleanorgb) linked an issue Aug 28, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the biogeochemical soil heating option (l_bgc_heat) so it can be used in UM-JULES configurations and with the 1-layer soil carbon setup, primarily by aligning the respiration/heating logic with the soil-carbon layer dimension (dim_cslayer) and removing prior “standalone-only” gating.

Changes:

  • Update soil_htc biogenic heating to use dim_cslayer (carbon-layer dimension) rather than nshyd (hydrology/soil moisture levels).
  • Remove UM-side unavailability checks and standalone rose-meta constraints/warnings that prevented enabling l_bgc_heat.
  • Add a new entry to CONTRIBUTORS.md.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/science/soil/soil_htc_jls_mod.F90 Switch biogenic heating loops/array shape to use dim_cslayer and add required module import/OpenMP shared var.
src/control/um/check_unavailable_options_mod.F90 Remove the UM runtime message that previously rejected l_bgc_heat.
src/control/shared/jules_soil_biogeochem_mod.F90 Relax configuration checks that previously required l_q10/l_layeredc for l_bgc_heat.
rose-meta/jules-standalone/HEAD/rose-meta.conf Remove standalone metadata restriction and warning tied to UM and l_q10 when using l_bgc_heat.
CONTRIBUTORS.md Add contributor entry.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/science/soil/soil_htc_jls_mod.F90

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix l_bgc_heat for one layer

3 participants