Inferno macro hotfix

[Pierre Siddall (Pierre-siddall)]

PR Summary

Code Reviewer: Sam Clarke-Green (@t00sa)

Quick hotfix to apply #141 macro which was missed

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• If editing rose-meta/jules-shared then have you supplied a linked UM and LFRic Apps PR?

Testing

• I have tested this change locally, using the JULES rose-stem suite
• If shared files have been modified, I have run the UM and LFRic Apps rose stem suites
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (eg. kgo changes)
• I have added tests to cover new functionality as appropriate (eg. system tests, unit tests, etc.)

trac.log

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

Approvals

Please request all relevant approvals. See the CodeOwners.txt file for section owners.

Technical

• JULES Code Owner
• OpenMP
• River Routing
• Rose Stem
• Rose Metadata
• Upgrade Macros

Scientific

• Surface
• Hydrology
• Vegetation
• Veg3 RED Demography
• Biogeochemistry
• Biogenic fluxes
• Fire
• Lakes
• Evaluation
• Imogen

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[Copilot]

Pull request overview

Hotfix updating multiple Rose Stem runtime app configurations to apply the fire-module macro changes from #141 (separating Fire Weather Index controls from the previous fire_switches namelist naming).

Changes:

• Update meta= references from jules-standalone/vn8.2 to jules-standalone/vn8.2_t141.
• Switch fire.nml to source namelist:jules_fire_weather_index instead of namelist:fire_switches.
• Rename l_fire to l_fire_weather_index via the new jules_fire_weather_index namelist block in each app.

Reviewed changes

Copilot reviewed 58 out of 58 changed files in this pull request and generated 57 comments.

Show a summary per file

File	Description
rose-stem/app/surf_gl9/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_vegdrag/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_ukv/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_trif/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_trif_spinup/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_prescribe_sthuf/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_julesc/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_julesc_spinup/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_layeredcn/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_layeredcn_spinup/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_es_1p0/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_es_1p0_spinup/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_es_1p0_deposition/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_es_1p0_deposition_spinup/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_es_1p0_biocrop/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_es_1p0_biocrop_spinup/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_es_1p0_biocrop_agexpand/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_cn/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_cn_spinup/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_c1p1/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_jules_c1p1_fire/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_irrig/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_irrig_nirrtile/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_gl8/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_gl8_medlyn/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_gl7/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_gl4/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_forecast/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_fire/rose-app.conf	Update fire namelist source and metadata tag (FWI enabled).
rose-stem/app/loobos_fire_spinup/rose-app.conf	Update fire namelist source and metadata tag (FWI enabled).
rose-stem/app/loobos_euro4/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_daily_disagg/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_crops/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_crm6_traitT/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_crm6_traitF/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_crm6_traitF_srfT/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_crm5_traitF/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_crm4_traitF/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/loobos_crm1_traitF/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/imogen_layeredc/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/imogen_layeredc_spinup/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_ukv/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_trip/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_trip_spinup/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_trip_restart/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_rivers/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_rivers_spinup/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_rivers_restart/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_gl7/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_gl4/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_euro4/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_es_1p1/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_closures/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_irrig_limit_low_river_storage/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/gswp2_irrig_limit_high_river_storage/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/eraint_trip_2ddata/rose-app.conf	Update fire namelist source and metadata tag.
rose-stem/app/eraint_rfm_2ddata/rose-app.conf	Update fire namelist source and metadata tag.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Sam Clarke-Green (t00sa)]

Changes look sensible and standalone jules testing passes. Approved.