Skip to content

Add WSMR missing crop surface types - #140

Draft
Maggie (maggiehendry) wants to merge 7 commits into
MetOffice:mainfrom
maggiehendry:136-add-wsmr-missing-crop-surface-types
Draft

Add WSMR missing crop surface types#140
Maggie (maggiehendry) wants to merge 7 commits into
MetOffice:mainfrom
maggiehendry:136-add-wsmr-missing-crop-surface-types

Conversation

@maggiehendry

@maggiehendry Maggie (maggiehendry) commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • If editing rose-meta/jules-shared then have you supplied a linked UM and LFRic Apps PR?

Testing

  • I have tested this change locally, using the JULES rose-stem suite
  • If shared files have been modified, I have run the UM and LFRic Apps rose stem suites
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system tests, unit tests, etc.)

trac.log

Test Suite Results - um - um-jules-136-add-wsmr-missing-crop-surface-types/run1

Suite Information

Item Value
Suite Name um-jules-136-add-wsmr-missing-crop-surface-types/run1
Suite User margaret.hendry
Workflow Start 2026-08-28T10:47:34
Groups Run suite_default
Dependency Reference Main Like
casim MetOffice/casim@2026.07.1 True
jules maggiehendry/jules@69c10be True
moci MetOffice/moci@2026.07.1 True
mule MetOffice/mule@2026.07.1 True
shumlib MetOffice/shumlib@2026.07.1 True
socrates MetOffice/socrates@2026.07.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2026.07.1 True
ukca MetOffice/ukca@2026.07.1 True
um maggiehendry/um@53230df True
um_aux MetOffice/um_aux@2026.07.1 True
um_meta MetOffice/um_meta@2026.07.1 True

Approvals

Code Owners

  • No UM Code Owners Required

Config Owners

No UM Config Owners Required

Task Information

✅ succeeded tasks - 895

Test Suite Results - lfric_apps - lfric_apps-jules-136-add-wsmr-missing-crop-surface-types/run1

Suite Information

Item Value
Suite Name lfric_apps-jules-136-add-wsmr-missing-crop-surface-types/run1
Suite User margaret.hendry
Workflow Start 2026-08-28T10:52:01
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2026.07.1 True
jules maggiehendry/jules@69c10be True
lfric_apps maggiehendry/lfric_apps@9151e67 True
lfric_core MetOffice/lfric_core@2026.07.1 True
moci MetOffice/moci@2026.07.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2026.07.1 True
socrates MetOffice/socrates@2026.07.1 True
socrates-spectral MetOffice/socrates-spectral@2026.07.1 True
ukca MetOffice/ukca@2026.07.1 True

Task Information

✅ succeeded tasks - 1210

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

Approvals

Please request all relevant approvals. See the CodeOwners.txt file for section owners.

Technical

  • JULES Code Owner
  • OpenMP
  • River Routing
  • Rose Stem
  • Rose Metadata
  • Upgrade Macros

Scientific

  • Surface
  • Hydrology
  • Vegetation
  • Veg3 RED Demography
  • Biogeochemistry
  • Biogenic fluxes
  • Fire
  • Lakes
  • Evaluation
  • Imogen

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Aug 18, 2026
@maggiehendry Maggie (maggiehendry) linked an issue Aug 19, 2026 that may be closed by this pull request
@maggiehendry Maggie (maggiehendry) changed the title WSMR varieties added to Rose stem tests; no code changed will fail. Add WSMR missing crop surface types Aug 19, 2026
@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Aug 19, 2026
@github-actions github-actions Bot added cla-modified The CLA has been modified as part of this PR - added by GA and removed cla-signed The CLA has been signed as part of this PR - added by GA labels Aug 28, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Hello Maggie (@maggiehendry)!

Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR.

Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-modified The CLA has been modified as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add WSMR missing crop surface types

2 participants