Preprocessors do not use flags defined in the tool. - #597
Merged
Conversation
github-actions
Bot
added
the
cla-required
github-actions
Bot
added
cla-signed
This was referenced Aug 17, 2026
Matthew Hambley (MatthewHambley)
requested a review
from Sam Clarke-Green (t00sa)
August 20, 2026 12:04
Sam Clarke-Green (t00sa)
approved these changes
Aug 21, 2026
Sam Clarke-Green (t00sa)
left a comment
Sam Clarke-Green (t00sa)
left a comment
Contributor
There was a problem hiding this comment.
Thanks, looks good to me.
github-actions
Bot
removed
the
cla-signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small bug fix.
This would potentially also allow us to simplify the preprocessor handling in fab_base (which atm is a separate list in the tool, instead the flags could be set both preprocessors - or we could even entirely remove this, and rely on fab scripts to set the flags in the preprocessor tool instead, though then the applications have to make sure they are defined for both, Fortran and C preprocessors). For now I considered that out of scope