567 psyclone transmute - #584
Open
Joerg Henrichs (hiker) wants to merge 19 commits into
Open
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Collaborator
Author
|
Ready for review. |
Joerg Henrichs (hiker)
added
the
Ready for review
Joerg Henrichs (hiker)
requested review from
a team and
Erica Neininger (ericaneininger)
and removed request for
a team
June 26, 2026 14:04
Matthew Hambley (MatthewHambley)
requested review from
Benjamin Went (MetBenjaminWent) and
Alistair Pirrie (mo-alistairp)
July 21, 2026 15:24
Sam Clarke-Green (t00sa)
requested review from
Sam Clarke-Green (t00sa)
and removed request for
Erica Neininger (ericaneininger)
July 23, 2026 08:07
github-actions
Bot
added
the
cla-signed
Collaborator
Author
|
Yaswant Pradhan (@yaswant) , Matthew Hambley (@MatthewHambley) , Sam Clarke-Green (@t00sa) Any updates on this PR? The next lfric core pr (#371 to add transmute support) needs this. |
25 tasks
Alistair Pirrie (mo-alistairp)
previously approved these changes
Aug 20, 2026
Alistair Pirrie (mo-alistairp)
left a comment
Alistair Pirrie (mo-alistairp)
left a comment
There was a problem hiding this comment.
I'm not familiar with the internal workings of fab, but from what I can tell the implementation looks sensible and that it would do the job
Sam Clarke-Green (t00sa)
requested changes
Aug 21, 2026
Sam Clarke-Green (t00sa)
left a comment
Sam Clarke-Green (t00sa)
left a comment
Contributor
There was a problem hiding this comment.
I've spotted a very minor typo but otherwise it all looks good and Alistair is happy, so it can go on as soon as it's ready
| # ############################################################################## | ||
| """ | ||
| A preprocessor and code generation step using PSyclone's transmute (Fortran to | ||
| Fortran) ability. . |
Contributor
There was a problem hiding this comment.
Suggested change
| Fortran) ability. . | |
| Fortran) ability. |
Collaborator
Author
There was a problem hiding this comment.
Done
github-actions
Bot
removed
the
cla-signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds code for a PSyclone transmute step.