Pyvista mesh generator - #96
Conversation
…ill point changing
This also revealed a bug in the splitting, where the start index was not accounted for properly.
Some of the content of this commit has been produced with the assistance of Met Office GitHub Copilot Enterprise
Some of the content of this commit has been produced with the assistance of Met Office GitHub Copilot Enterprise
Some of the content of this commit has been produced with the assistance of Met Office GitHub Copilot Enterprise
|
Noting that there was a failing unit test in the split mesh-to-grid regrid (
Expected: global-to-global mesh-to-grid regrid. There are a bunch of masked points (the white points in the plot), which appear masked in both the expected and actual (due to SciTools/iris-esmf-regrid#391, now fixed in later versions of As a result I have decided to increase the source data resolution for this test from C4 to C12 (splitting a C4 into 4 bands is a fairly unrealistic test of our banded regrid): 302a055 |

Closes #92 . Closes #59
To be completed prior to review request and updated as required during the review process.
If the answer to an item on the list is not applicable, feel free to replace the checkbox with 'N/A' to give extra clarity.
All developers are reminded to follow the ancil working practices
Branch
Related branches (e.g. ug-ancillary-file-science):
N/A
UG-ANTS rose stem logs
UG-ANTS/run2
ug-ancillary-file-science rose stem logs
ug-ancillary-file-science/run4
Testing
For core UG-ANTS only tests, the bare minimum that will be accepted is the
group=unittestsbut many, if not most, changes will need to test other groups to ensure they meet reviewer expectations. In general, it should be possible and is advised to run thegroup=allgroup prior to review submission as this will catch any consequential issues. Additionally you must run the ug-ancillary-file-science tests, pointing at your branch, withgroup=allto capture any behaviour changes affecting Science codes.If your change will alter existing science results, you will need to seek appropriate Scientific validation and confirm that the model has been initialised with your new development. Inspecting a change in xconv/pyplot/visualiser of choice is not sufficient to demonstrate the model can be initialised from your file.
Impact of change
cylc vip ./rose-stem -z group=alltestscylc vip ./rose-stem -z group=alltestsApprovals for this change
New functionality further testing
These tasks must succeed for your ticket to pass review.
Other
Please add any further notes here. If Generative AI tools have been used, a brief summary should be provided.
GitHub copilot used to add unit tests for the new stock mesh/cube generators
Rose stem logs
Please copy in the contents of your trac_status.log file(s) below (found in the cylc-run directory for your rose stem run) to your rose-stem testing here. Note: if your changes lead to a change in answers, you must run
cylc vip ./rose-stem -z group=allto help ensure all affected configurations has been flagged up.Test Results - Summary
Test Results - Detail
Test Results - Summary
Test Results - Detail