Skip to content

Multidimensional and multi-field fill application - #88

Draft
Josh Rackham (jrackham-mo) wants to merge 8 commits into
MetOffice:mainfrom
jrackham-mo:22-multidimensional-fill
Draft

Multidimensional and multi-field fill application#88
Josh Rackham (jrackham-mo) wants to merge 8 commits into
MetOffice:mainfrom
jrackham-mo:22-multidimensional-fill

Conversation

@jrackham-mo

Copy link
Copy Markdown
Collaborator

Closes #22

To be completed prior to review request and updated as required during the review process.

If the answer to an item on the list is not applicable, feel free to replace the checkbox with 'N/A' to give extra clarity.

All developers are reminded to follow the ancil working practices


Branch

Related branches (e.g. ug-ancillary-file-science):

[please link any related branches here]

UG-ANTS rose stem logs

[please enter the workflow name here as it has been run e.g. ug-ants-trunk/run5]

ug-ancillary-file-science rose stem logs

[please enter the workflow name here as it has been run e.g. ug-ancillary-file-science/run1]


Testing

For core UG-ANTS only tests, the bare minimum that will be accepted is the group=unittests but many, if not most, changes will need to test other groups to ensure they meet reviewer expectations. In general, it should be possible and is advised to run the group=all group prior to review submission as this will catch any consequential issues. Additionally you must run the ug-ancillary-file-science tests, pointing at your branch, with group=all to capture any behaviour changes affecting Science codes.

If your change will alter existing science results, you will need to seek appropriate Scientific validation and confirm that the model has been initialised with your new development. Inspecting a change in xconv/pyplot/visualiser of choice is not sufficient to demonstrate the model can be initialised from your file.


Impact of change

  • This will maintain results for UG-ANTS cylc vip ./rose-stem -z group=all tests
  • This will this maintain results for ug-ancillary-file-science cylc vip ./rose-stem -z group=all tests
  • If this change adds a new capability, evidence has been supplied to show testing of ancillary generation across different resolutions e.g. For global ancillary generation capabilities for use in NWP C896 is expected to have been tested
  • This change has significantly impacted required resources (runtime and memory) in existing ancillary generation (if yes, give details)
  • This change alters existing ancils
Add further comments/details for your reviewers here on the impacts of the change......

Approvals for this change

  • I have approval from the UG-ANTS core development team for these changes

New functionality further testing

  • If adding new functionality to existing codes, I confirm that the new code doesn't change results when it is switched off and ''works'' when switched on
  • Unittests have been added
  • Rose stem tests have been added for any new functionality
  • I have not encountered any failures in my rose-stem output(s)
    These tasks must succeed for your ticket to pass review.
  • I have remembered to run the code style check tasks/tools
Add details of any further testing here.

Other

  • I have read the Contributor Licence Agreement
  • I have added my name and affiliation to the Contributors list if I am not already on there in this PR.
  • The ticket labels, milestones, etc. are correct
  • Links to all related tickets have been provided in the ticket description
  • I have requested a code reviewer
  • Source data has been added or changed - please include a link to the license
I confirm that all code is my own and that my contributions are not subject to copyright or license restrictions (see Contributor Licence Agreement). your name
I confirm I have not knowingly violated intellectual property rights (IPR) and have taken sensible measures to prevent doing so, including appropriate attribution for usage of Generative AI. I confirm that this work is my own, and I understand that it is my responsibility to ensure I am not violating others’ IPR. This includes taking reasonable steps to ensure that all tools used while creating this contribution did not infringe IPR. your name
Please add any further notes here. If Generative AI tools have been used, a brief summary (e.g. "Github copilot used to add extra unittests") should be provided.

Rose stem logs

Please copy in the contents of your trac_status.log file(s) below (found in the cylc-run directory for your rose stem run) to your rose-stem testing here. Note: if your changes lead to a change in answers, you must run cylc vip ./rose-stem -z group=all to help ensure all affected configurations has been flagged up.

Add workflow_status.log contents for UG-ANTS rose-stem here.

Add trac_status.log contents for ug-ancillary-file-science rose-stem here.

…-fill

* upstream/main:
  Add release notes for 0.5.0 (MetOffice#72)
  Rename contrib references (MetOffice#71)
  Fix counts table counts query (MetOffice#66)
  Update PR template to cylc vip and correct group setting (MetOffice#68)
  Add automated code style checks (MetOffice#67)
  Update _version.py (MetOffice#54)
  Add PR template (MetOffice#53)
  MetOffice#51:  Add accessibility statement
  Fix version string issues (MetOffice#50)
  Add changelog for 0.4.0 (MetOffice#48)
  Update trac ticket references (MetOffice#44)
  Clean history attributes (MetOffice#32)
  Port fix_mask as align_mask (MetOffice#34)
  Updated icon to point to github rather than trac (MetOffice#42)
  Consistency with ANTS for linking to contributing.rst from readme.rst (MetOffice#41)
  Update CLA for GitHub (MetOffice#40)
  Use setuptools-scm to update the version metadata (MetOffice#30)
  Update department in CLA (MetOffice#29)
  18 packaging (MetOffice#19)
@jrackham-mo Josh Rackham (jrackham-mo) added the ✨ enhancement Feature request for new capability label Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ enhancement Feature request for new capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow fill application to operate on multiple fields and multidimensional data

1 participant