Update fallback version post 3.2.0 tag - #155
Conversation
Signed-off-by: Josh Rackham <144251043+jrackham-mo@users.noreply.github.com>
Theo Geddes (mo-tgeddes)
left a comment
There was a problem hiding this comment.
Docs build shows 3.3.0dev as expected and so does ants-version, printing ants.__version__ in python gives 0.1.dev23+g885fdb3ef. Is that the expected behaviour?
|
Thanks Theo Geddes (@mo-tgeddes), this has exposed a bit of an issue with our current process for tagging, and how it integrates with setuptools-scm. Since we have tagged v3.2.0 on a commit on the v3.2.x branch, it is not reachable in the history of main. That means setuptools-scm can't find it, and goes back further than it should to find the next tag. Side note, it should find the 3.1.0 tag, since that was made on main. How are you testing this? You may need to re-run This has made me rethink our release process. The motivation for doing the release branch approach was that there are quite a few small changes that need to be made as part of the release. This is mostly hard-coding stuff to the release version, which hopefully we can set dynamically somehow. I'd like to look at this in time for the next major release (4.0). For the time being, I'm happy to accept that the version string will be wrong if you're installing from a non-released version of the code. |
|
#157 created to address tagging approach |
Theo Geddes (mo-tgeddes)
left a comment
There was a problem hiding this comment.
Works fully now. Was user error on my part. Apologies!
Update the fallback version to 3.3.0dev.