Skip to content

Update fallback version post 3.2.0 tag - #155

Merged
Josh Rackham (jrackham-mo) merged 1 commit into
MetOffice:mainfrom
jrackham-mo:update-fallback-version
Jun 24, 2026
Merged

Update fallback version post 3.2.0 tag#155
Josh Rackham (jrackham-mo) merged 1 commit into
MetOffice:mainfrom
jrackham-mo:update-fallback-version

Conversation

@jrackham-mo

@jrackham-mo Josh Rackham (jrackham-mo) commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Update the fallback version to 3.3.0dev.

Signed-off-by: Josh Rackham <144251043+jrackham-mo@users.noreply.github.com>

@mo-tgeddes Theo Geddes (mo-tgeddes) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs build shows 3.3.0dev as expected and so does ants-version, printing ants.__version__ in python gives 0.1.dev23+g885fdb3ef. Is that the expected behaviour?

@jrackham-mo

Copy link
Copy Markdown
Collaborator Author

Thanks Theo Geddes (@mo-tgeddes), this has exposed a bit of an issue with our current process for tagging, and how it integrates with setuptools-scm. Since we have tagged v3.2.0 on a commit on the v3.2.x branch, it is not reachable in the history of main. That means setuptools-scm can't find it, and goes back further than it should to find the next tag.

Side note, it should find the 3.1.0 tag, since that was made on main. How are you testing this? You may need to re-run pip install -e . into a developer environment, setuptools-scm only runs at install time. Another problem I've hit before is that tags aren't propagated to forks automatically, you need to git pull --tags from upstream, and git push --tags to origin to get them on your fork.

This has made me rethink our release process. The motivation for doing the release branch approach was that there are quite a few small changes that need to be made as part of the release. This is mostly hard-coding stuff to the release version, which hopefully we can set dynamically somehow. I'd like to look at this in time for the next major release (4.0).

For the time being, I'm happy to accept that the version string will be wrong if you're installing from a non-released version of the code.

@jrackham-mo

Copy link
Copy Markdown
Collaborator Author

#157 created to address tagging approach

@mo-tgeddes Theo Geddes (mo-tgeddes) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fully now. Was user error on my part. Apologies!

@jrackham-mo
Josh Rackham (jrackham-mo) merged commit 0ee5c8a into MetOffice:main Jun 24, 2026
5 checks passed
@jrackham-mo
Josh Rackham (jrackham-mo) deleted the update-fallback-version branch June 24, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants