fix(api): return JSON 500 when bucketed telemetry query fails - #137
Merged
Merged
Conversation
The bucketed branch declared a new err with :=, so a store error never reached the outer check and the handler dereferenced a nil telemetry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getObserverTelemetrydeclared a fresherrwith:=inside the bucketed branch, so a failingGetObserverTelemetryBucketednever reached the outer error check.telemetrystayed nil and the handler panicked ontelemetry.Range = ...; chi's recoverer turned that into a bare 500 with no{"error": ...}body. Only reachable withinterval=6hor24h, the 7d/30d charts in beacon-web.Assigns with
=instead, and adds a handler test that stubs a store error on the bucketed path and asserts a JSONinternal_server_errorresponse. The test panics without the fix.Closes the
telemetry-bucketed-error-panicticket in beacon-docs.