fix(observers): rename telemetry airtime fields to seconds - #136
Merged
Merged
Conversation
airtime_tx_pct/airtime_rx_pct always held the observer's tx_air_secs / rx_air_secs counters, never a percentage. Rename the columns and the airtimeTxPct/airtimeRxPct response fields to *Secs. Values are unchanged: cumulative since boot on 1h points, per-bucket delta on 6h/24h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
airtime_tx_pct/airtime_rx_pctonobserver_telemetry, and theairtimeTxPct/airtimeRxPctfields on/observers/{id}/telemetry, have always carried the observer'stx_air_secs/rx_air_secscounters in seconds. Nothing ever divided by wall-clock time. This renames them to say what they are.ALTER TABLE ... RENAME COLUMNfor both columns. Metadata only, no rewrite.ObserverTelemetryPointrenamed toairtimeTxSecs/airtimeRxSecs. Values unchanged: cumulative since boot oninterval=1h, per-bucket delta on6h/24h.Response shape change
The frontend field rename is already on beacon-web
dev, and beacon-docsapi_contract.mddocuments the new names and semantics. Deploy the server before or together with the web build; a web build that reads*Secsagainst a server still sending*Pctshows an empty airtime chart.