Repository navigation
A build declares whether it takes MeshCore's console commands - #791
Merged
Merged
Conversation
A build's settings gain dialect. A node running one that is not MeshCore's is not provisioned (the script is one comment saying why), and experiment.start refuses an arm that would pin a setting onto it. Settable at import, on firmware.update, and from the build's window. Closes #599.
… one image's dialect is not read off another's
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #599.
dialect:meshcore(the default, stored as nothing),none, or another firmware's name. It is settable onfirmware.importandfirmware.update, reported byfirmware.details, and has a switch in the build's window ("takes MeshCore's console commands").# Deck runs wadamesh firmware, which does not take MeshCore's console commands: nothing is sent. Both the boot path and experiment cells already skip comments, so nothing is typed at it. The Provisioning panel shows that line.experiment.startrefuses an arm that pins settings (path hash, loop detect, CAD,set:) onto such a node, naming the arm and the nodes. Each node is judged on the build that arm runs it on. An arm that only chooses builds is not refused.docs/firmware-build-settings.mdhas a section on it.Tests cover a wadamesh build provisioned with nothing, a MeshCore build left alone, and the arm refusal. One Python client test (
test_a_development_workbench_is_served...) fails locally on main too, so it is unrelated.