Repository navigation
Renode chip binding: structs to ABI 1.7, accept 1.8; pin virtual-sx1262 v1.5.0 - #783
Merged
Merged
Conversation
VsxState and VsxCounters were ABI 1.3 shapes while the version check let any later minor in, so a 1.4+ library wrote past both. Both now follow the 1.7 header; their sizes are checked against C's on load, and a minor above 1.7 is refused until they are brought up to it. The stats record goes to 47 bytes: ConsoleBaud (zero) and, from a chip at 1.4 or later, irq_suppressed. An older chip's record stops at 43 so the engine reads the count as absent, not zero. Closes #747.
A13xB0
force-pushed
the
fix-747-renode-abi
branch
from
October 30, 2026 17:06
9589b62 to
e2b3f69
Compare
A13xB0
changed the title
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #747.
VsxStateandVsxCountersnow follow virtual-sx1262's 1.7 header field for field. Each group is commented with the minor that appended it.irq_suppressed. A chip older than 1.4 does not count suppressed IRQs, so its record stops at 43 bytes and the engine reports the count as absent rather than 0.Tested live: a RAK_4631 repeater under Renode, against both the pinned 1.3.1 library and one built from virtual-sx1262 main (1.7). Both boot and transmit, with the same airtime.
irq_suppressedisnullon 1.3.1 and0on 1.7.Not done: the issue's third point, sized
vsx_get_state/vsx_get_counters. That is a virtual-sx1262 change. The pin itself is not bumped here either.Also accepts ABI 1.8 (virtual-sx1262 v1.5.0 appended nothing to the structs) and pins v1.5.0 for emulated boards, in packaging/emulator-pins.env and the toolchain catalogue.