Integrate last sign in #551
Open
+82
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add attribute to API response - extend the schema - diplay the value on account detail page
varmar05
reviewed
Jan 13, 2026
| workspace_role: str | ||
| project_role: Optional[ProjectRole] | ||
| type: str | ||
| last_signed_in: str |
Collaborator
There was a problem hiding this comment.
do we want this optional?
|
|
||
| <div class="flex flex-column justify-content-between"> | ||
| <p class="title-t4 overflow-wrap-anywhere"> | ||
| {{ fullName ? `${fullName} (${username})` : username }} |
Collaborator
There was a problem hiding this comment.
I am bit confused - is fullname optinal or always set with username as fallback (from api response)?
Collaborator
|
@harminius can you check tests? I thought we already fixed gevent timeout issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/MerginMaps/server-private/issues/3077
Adds
+last_signed_ininformation for all collaborators in APIUpdates