Fix anchor link positions in Chrome #708
Open
+190
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varmar05
approved these changes
Jan 12, 2026
brc-dd
reviewed
Jan 12, 2026
| @@ -1,5 +1,5 @@ | |||
| // https://vitepress.dev/guide/custom-theme | |||
| import { h } from "vue"; | |||
| import { h, nextTick, watch } from "vue"; | |||
brc-dd
reviewed
Jan 12, 2026
Comment on lines
+160
to
+163
| h1, h2, h3, h4, h5{ | ||
| /** For proper anchor offset when using scroll to hash links */ | ||
| scroll-margin-top: 60px; | ||
| } |
There was a problem hiding this comment.
scroll-margin-top is not yet respected by vitepress' router. If you want this it needs to be configured in .vitepress/config, but the defaults already calculate the offset depending on the height on navbar, etc.. Probably can be removed.
brc-dd
reviewed
Jan 12, 2026
Comment on lines
+49
to
+52
| if (style.length > 0) { | ||
| const sep = existingStyle && !existingStyle.trim().endsWith(';') ? ';' : '' | ||
| token.attrSet('style', existingStyle + sep + style.join(' ')) | ||
| } |
There was a problem hiding this comment.
This version works, but probably can be synced with the edits on the vitepress issue. I had made it simpler (just using string for styles as there is only one concat needed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #656
Solution
After some discussion with @brc-dd in vitepress issues (see: vuejs/vitepress#5079), following improvements were implemented: