Raise NameError for unresolvable forward-ref annotations#2
Open
yashwant86 wants to merge 4 commits intomasterfrom
Open
Raise NameError for unresolvable forward-ref annotations#2yashwant86 wants to merge 4 commits intomasterfrom
yashwant86 wants to merge 4 commits intomasterfrom
Conversation
The test implies that the code that causes coverage issue won't be run
WalkthroughWhen a FastAPI route or dependency uses a type annotation that cannot be resolved at runtime — such as a type imported only under Changes
Sequence DiagramsequenceDiagram
participant App as FastAPI App
participant Router as Route Registration
participant DepUtils as get_typed_annotation
participant EvalRef as evaluate_forwardref
App->>Router: @app.get("/") with annotated param
Router->>DepUtils: get_typed_annotation(annotation, globalns)
alt annotation is string
DepUtils->>DepUtils: Convert to ForwardRef
end
alt annotation is ForwardRef
DepUtils->>EvalRef: evaluate_forwardref(ref, globalns, globalns)
EvalRef-->>DepUtils: resolved type or unchanged ForwardRef
alt result is still ForwardRef
DepUtils-->>Router: raise NameError("Could not resolve...")
Router-->>App: NameError propagates
else result is resolved type
DepUtils-->>Router: return resolved type
end
else annotation is concrete type
DepUtils-->>Router: return annotation unchanged
end
Dig Deeper With Commands
Runs only when explicitly triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of fastapi#15307
Summary by MergeMonkey