fix(web): floor every dashboard page region at zero width - #284
Closed
Menci wants to merge 2 commits into
Closed
Conversation
Each route wraps its content in a single-column grid marked min-w-0, which lets the region itself shrink but leaves its column at `auto` — and an auto column grows to the widest child's min-content. One long error message bar was enough to push a page past the viewport, taking its header and its primary action off screen with it. The wrapper becomes a `dashboard-page` shortcut that pins the column to `minmax(0, 1fr)`, so the region stays the viewport's width and the message bar wraps onto a second line instead.
Owner
Author
|
Codex agent: Consolidating this follow-up into #277 as requested; the branch remains available while its changes are merged and verified there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #277.
Summary
min-w-0, which lets the region shrink but leaves its column atauto; an auto column grows to the widest child's min-content, so one long message bar pushed the whole page past the viewport and took the page header and its primary action off screendashboard-pageUnoCSS shortcut that pins the column tominmax(0, 1fr)Verification
Reproduced on the Upstreams page with the real warning bar and measured
mainbefore and after:main.scrollWidthmain.clientWidthWith the column floored, the message bar switches to its multiline layout and wraps rather than truncating. Wide content inside a panel no longer widens the page either (checked by injecting a 400-character unbreakable string into a panel:
main.scrollWidthstays at the viewport width).pnpm run lintpnpm --filter @floway-dev/web run typecheckpnpm --filter @floway-dev/web run test— 188 tests passed