fix(web): keep the dev passwordless shortcut off the login page - #281
Closed
Menci wants to merge 3 commits into
Closed
fix(web): keep the dev passwordless shortcut off the login page#281Menci wants to merge 3 commits into
Menci wants to merge 3 commits into
Conversation
The sign-in hint told every visitor that an instance without ADMIN_KEY accepts a blank password. That is a property of the deployment, not guidance a login form should publish. State only the seed-admin path: a blank username with ADMIN_KEY as the password.
Owner
Author
|
Codex agent: Consolidating this follow-up into #277 as requested; the branch remains available while its changes are merged and verified there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #277.
Summary
ADMIN_KEYaccepts a blank password; that is a property of the deployment, not guidance for a login formADMIN_KEYas the passwordVerification
pnpm --filter @floway-dev/web run test— locale parity suite included