fix(memory): route Qwen thinking through chat template kwargs - #312
Open
LeslieWylie wants to merge 1 commit into
Open
fix(memory): route Qwen thinking through chat template kwargs#312LeslieWylie wants to merge 1 commit into
LeslieWylie wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for working on this! I suggest adding chat_template_kwargs later as part of dedicated SGLang/vLLM providers. Adding it to the generic OpenAI-compatible path now could affect existing cloud-provider calls and introduce unnecessary risk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable_thinkingthroughchat_template_kwargswhen an OpenAI-compatible endpoint opts into that transportValidation
npx vitest run Memory/tests/llm-thinking.test.ts(19 tests passed)enable_thinking=falsewas ignored whilechat_template_kwargs.enable_thinking=falseproduced zero reasoning tokens and valid JSON