fix(release): validate compare target explicitly - #245
Merged
syzsunshine219 merged 1 commit intoAug 17, 2026
Merged
Conversation
Collaborator
Author
|
Project Harness review handoff marker. Only reviews submitted strictly after this GitHub timestamp qualify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The merged v1.0.7 release Action (run 32009739539) failed in
Build complete release change snapshot. GitHub Compare REST responses do not contain a top-levelhead_commit, so reading.head_commit.shaalways returned empty and triggered a false identity mismatch.Fix
GET /repos/{owner}/{repo}/commits/{TARGET_SHA}.head_commit.shavalidation against the trusted checkout.TARGET_COMMIT_METADATA.jsonwith the release audit artifact.head_commitand prevents the invalid read from returning.Verification
13bf60f3d97a16a5f9fd76e578d36b5564fa1660againstmain@5fd094b1b8a04151d506cdbfc68b4b52b0cb42df.Recovery after merge
Do not rerun the old failed event. After this PR is merged, manually dispatch
GitHub Draft Release v2frommainwith:version:1.0.7preflight_level:fullcreate_draft:truetarget_sha: leave emptyThere is currently no
v1.0.7Tag or Release. This PR does not create, move, or publish either one. A different MemTensor maintainer must independently review and approve this T3 change.