Fix #39: memos add 成功但立即 get/list 查不到;且不存在 memos list 子命令 - #40
Closed
Memtensor-AI wants to merge 0 commit into
Closed
Fix #39: memos add 成功但立即 get/list 查不到;且不存在 memos list 子命令#40Memtensor-AI wants to merge 0 commit into
memos list 子命令#40Memtensor-AI wants to merge 0 commit into
Conversation
Collaborator
Author
🤖 Open Code ReviewTarget: PR #40 ✅ OpenCodeReview: Review skipped: no items were selected. Generated by cloud-assistant via Open Code Review. |
Collaborator
Author
🔧 Open Code Review requested Agent fixOpen Code Review found 10 issue(s). I have resumed the development Agent to fix them.
The Agent will push a new commit to this PR branch. OCR will recheck after the commit is pushed. |
Memtensor-AI
force-pushed
the
bugfix/autodev-39-20260826075659787
branch
from
August 26, 2026 09:18
2a704dc to
8efa86a
Compare
Collaborator
Author
🔧 Open Code Review Agent fix completedThe development Agent has pushed an OCR fix to this PR branch.
Summary: 已针对 PR #40 完成 OCR 第 1 轮 10 条 finding 的最小修复并推送到同一分支。修复:poll 前置 deadline 检查 + 异常日志、duration_ms 排除 polling、output.py 悬空标点/死分支、测试补零超时/null/精确 poll 次数/命令注册 guard。57 个单元测试全绿。 Open Code Review will recheck this PR after the new commit is observed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #39 — the
memos add/memos getrace and the missingmemos listcommand.memos addprinted "memory added" while the server was still asynchronously extracting/storing, so a follow-upmemos getfrequently returned empty results.memos listwas referenced in MemOS CLI.md and skill docs but never registered in main.py.Fix: (1) Registered
memos listas an alias ofmemos get(same callback, same options, same output). (2) Added--wait / --no-wait(default--wait) and--wait-timeout(default 30s) options tomemos add; when atask_idis present in the add response and status is "running", the CLI now polls/get/statusuntil the task reaches a terminal state or the timeout elapses. (3) Rewrote the add success formatter to surfacetask_idand reflect the true final state (Memory addedon completed, "still processing" hint on timeout, "accepted; task_id=..." on--no-wait,Memory add failedon terminal failure). (4) Updated README.md and README-zh.md to document the new options and thelistalias.Verification: full unit-test suite passes (56 tests, +15 new in
tests/test_memory_add_wait.py) covering task_id extraction, polling until completion,--no-waitskipping polling, timeout guard, typer wiring, list-alias registration, and all four output branches. Manualmemos --help,memos add --help, andmemos list --helpoutput confirmed. The change is a strict superset of the old contract — responses without atask_idfall back to the original behaviour, so servers that don't return an async id are unaffected.Related Issue (Required): Fixes #39
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Not run; documentation-only change.
Checklist
@lijicode please review this PR.
Reviewer Checklist
memos list子命令 #39