chore: Adding '.Values.global.imagePullSecrets' #1616
Open
heyvister1 wants to merge 1 commit into
Open
Conversation
heyvister1
force-pushed
the
fix-image-pull-secrets
branch
2 times, most recently
from
July 6, 2025 19:56
4ecf04d to
4f50e4c
Compare
Collaborator
Pull Request Test Coverage Report for Build 16109248994Details
💛 - Coveralls |
heyvister1
force-pushed
the
fix-image-pull-secrets
branch
from
July 7, 2025 06:19
4f50e4c to
aa95443
Compare
… network-operator sub-charts Signed-off-by: Ido Heyvi <iheyvi@nvidia.com>
heyvister1
added
the
on hold
Collaborator
Author
|
Should be on-hold until changes will get merged in nfd upstream |
rollandf
reviewed
Jul 8, 2025
| imagePullSecrets: [] | ||
|
|
||
| # -- Global values to be propagated into Network-Operator sub-charts | ||
| global: |
Member
There was a problem hiding this comment.
The format seems different between charts. May be problematic.
Some uses:
imagePullSecrets:
- name: my-secret
Other uses:
imagePullSecrets:
- my-secret
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding global attribute in values.yaml, to be able to propagate root chart values into sub-charts. For example network-operator global
imagePullSecretsintonode-feature-discoverysub-chart