Repository navigation
Phase 8: More maps (water-bearing sand, water level change) - #8
Merged
Merged
Conversation
…, gaps make the thickness rough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two more modes on the City map (spec:
docs/superpowers/specs/2026-10-14-stratavision-more-maps.md).Made-up test data: every third borewell also has a reading from 2023, so the real-app test sees a trend.
Checks: 162 unit tests (thickness rules; line through readings; repeat readings under a year ignored; same-borewell trends preferred and nearer counting more; area trend thresholds; a borewell's own level kept without double counting; readings with only a pumping level); the real-app test checks 10 borewells with repeat readings; screenshots of both modes checked.
Review fixes: a borewell whose readings have only a pumping level dropped out; the area trend needed far more readings; gaps make the thickness a rough guess; the slider can now reach the deepest step for thickness; clearer trend key.
Follow-up in StrataField (not here): adding the first later reading overwrites the borewell's drilling-time water level, so that first comparison is lost.