Repository navigation
Phase 7: City map - #7
Merged
Merged
Conversation
…ap, the map kept on the city with square cells
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A City map tab: the model painted over the whole city, in three modes.
In every mode the colour is strong where likely, pale where a rough guess, and clear where there is not enough data. Each mode has its key, and the panel says how big each square is and that these are proposals, not measurements.
How: about 10,000 square cells over the borewells plus 2 km, kept within the ground-height data. They are worked out a few at a time after the tab is first opened, with progress shown, so the screen stays responsive (a few seconds for 500 borewells). The picture lies under the borewell pins. No new libraries.
Checks: 141 unit tests (codes and levels per step, the first water-bearing sand ≥ 10 ft, unknown ground, area margin, staying within the ground data, square cells, painting per mode); the real-app test opens the City map; screenshots of all three modes checked.
Review fixes: "Working out the map…" forever with nothing to map; the map hid the borewell pins; one far-off borewell stretched the map over 100 km; cells were not square; the slider before the map was ready; the mode choice is now real radio buttons; "300+" on the water-bearing key.