Repository navigation
Phase 6: 3D slice - #6
Merged
Merged
Conversation
…, keys that tilt as dragging does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 3D slice on the Section screen: switch the drawing from "Flat drawing" to "3D slice" and the section becomes a block cut out of the ground, like a slice of cake.
Checks: 140 unit tests (left offset, mitred and capped corners, no fold-over after short parts, faces and their direction, pins only behind the line, one height range); the real-app test switches to the 3D slice; screenshots checked for a straight and a bent line from two angles.
Review fixes: the back folded over where a short part followed a bend inwards; the block was far too tall on short lines; the arrow keys tilted the opposite way to dragging; the turnable view is announced as a 3D view with its instructions.
Not done: map tiles on the top (it is plain land colour); a borewell just past a bend can show on both neighbouring sides.