Repository navigation
Phase 5: Section - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Section screen: draw a line (it can bend) on the map, and see the ground along it.
New libraries (all already used by StrataField):
pdf-lib, Tauri's dialog and fs plugins (Save dialog only; the records stay read-only).Checks: 131 unit tests (section along a bent line, sloping ground, corridor, missing ground height, water, repeated points, PDF page, saved-picture colours and text size); a 500-borewell section takes ~75 ms; the real-app test draws a section on made-up borewells.
Review fixes: the saved picture lost the 11px text size; repeated points made fake bends; borewells just past the ends are drawn at the ends; the right message off the ground-height data; "How good are these estimates?" link on this screen too.