Repository navigation
Phase 2: the model (weighted vote, confidence, accuracy check) - #2
Merged
Merged
Conversation
…acy check, a harder made-up city - Layer depths are always feet in StrataField; the metres conversion was wrong and is gone. - No spot gets more than 3 of the 12 votes, so a place with many logs cannot crowd out the rest. - The accuracy check hides everything at a borewell's spot, takes the distance step by step, keeps guesses it would not show out of the headline, and needs 5 borewells to call one odd. - The made-up ground now has layers that thin out and vanish; the model must beat guessing by height alone, and must find most logs planted upside down. - The map timing limit is looser on CI runners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of the design: the calculation behind everything StrataVision will show. No screens use it yet, so the app looks the same as after phase 1.
What it adds
predictColumn). For a point, in 5 ft steps: nearby borewells that reach that height vote, closer ones count more, poor records and address-located borewells count less. Borewells at one spot share a vote and take at most 3 of the 12 seats. Layers are compared by height above sea level, not depth. Each step says the share for each group, the likeliest, a confidence (likely, rough, none) and which borewells it came from.checkModel). Hides each borewell in turn, with everything else at its spot, predicts it from the rest and counts how often the best guess was right, split by confidence and by distance. Also lists odd ones out: borewells that disagree with their surroundings far more than usual.On a made-up city of 500 borewells
The true ground is known, layers thin out and vanish from place to place, and 30% of borewells share a spot with another.
With 50 of the 500 logs typed in upside down, the check listed 40 of them as odd ones out, along with 7 honest ones.
More borewells gave a better score (100 vs 500).
These logs are clean and exactly placed, so real records will score lower. The constants get tuned against real records in phase 3.
Corrected after review
Checks
60 TypeScript tests (new in this PR; CI now runs them), 8 Rust tests, the start-up test of the real app.