Repository navigation
Help placing borewells, read a Location line, and an Excel log template - #81
Merged
Merged
Conversation
- Placing a borewell opens the map on borewells already placed at the same site or colony, shown by name; the spot is always clicked, since borewells on one site are in different places. - The address is searched as written, then with other spellings the map uses, then by shorter parts; matches from elsewhere are not offered. Stored addresses are never changed. - The Excel reader takes a 'Location = ...' line (numbers or a Google Maps link), and no longer mistakes a title such as 'STRETA CHART OF TUBE WELL' for the chart's heading. - Save an Excel template on the Import screen: a blank log laid out the way the reader expects, tested by filling it in and reading it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three things that make getting borewells onto the map less work, and an Excel template for drilling logs.
Placing borewells starts from where DWO has worked before
When a borewell's name or address shares a place with borewells already on the map ("Ekana", "Talkatora", "Vrindavan"), the map picker opens there with those borewells shown by name. It is only a view: the spot is always clicked, because borewells on one site are in different places (the six at Ekana are each somewhere else on the stadium land). Used on Add locations and on the Import screen.
Finding an address works better
The address is searched as written first (plot number and all), then with other spellings the map uses for the same place (Haiderabad / Hyderabad, Chinhut / Chinhat, Dewa / Deva, Extention / Extension, Sect / Sector), then by ever shorter parts ("Sector C, Mahanagar", then "Mahanagar"). A match is only offered when it has every telling word of the search and is within 40 km of Lucknow: the old search offered Jagat Narain Road for "Prag Narain Road", and places in Delhi or Karachi. Stored addresses are never changed. An address with nothing particular to search for ("Station Road") is searched as before.
A position written on a log is imported
A line such as
Location = 26.8912, 80.9876, or a Google Maps link, is read with the log and fills the location on the Import screen.Save an Excel template (Import screen)
A blank log laid out the way the reader expects (details down column A, soil chart in B–D, pipe in F–H), with a filled-in example, the soil and pipe names to use, and instructions. Built from code in
core/src/export/logTemplate.tsand tested together with the reader: the example is read back exactly, after being saved as a real .xlsx file. A copy filled in cell by cell in Excel was also read back with nothing to correct.Reader fix
A title such as "STRETA CHART OF TUBE WELL" above the chart was taken for the chart's heading, so such logs needed their columns chosen by hand. Only short cells ("Streta Chart", "Lowering Assambly") count as headings now. Over DWO's 80 real logs, the only change is that one more log (Dr D P Singh) reads on its own; every other log reads exactly as before.
Checks
places.test.ts,logTemplate.test.ts).