Repository navigation
sign_in: refuse a username that differs from the account the page shows - #341
Merged
Merged
Conversation
…age shows (#339) A password-only step shows a fixed account (hidden or read-only username, account chip, or the address near the password field). sign_in now fills only the saved login for that account: with no username it picks the match, and a different username or no match is username_mismatch, nothing filled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #339. A session's sign_in on a password-only step filled a saved login whose username did not match the account the page asked for, and the page refused it.
pageUsernamealso says whether the account is fixed (hidden or read-only input, account chip, address in nearby text). An editable username field is not fixed, since the fill overwrites it.sign_inwith no username picks the matching login; a different username, or no saved login for that account, isusername_mismatchwith the saved usernames, and nothing is filled.Local: typecheck green; unit tests pass except the pre-existing "managed: the options page saves only the changed key" failure (also on main).