Repository navigation
verify_code: serve Apple Passwords codes on every site (#339) - #340
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify_code now has a second code source for non-Apple hosts: the one-time codes Apple Passwords offers for the tab (authenticator codes saved for the site; Messages/Mail codes on Mac), picked by optional username. Apple sign-in hosts keep the prompt reader and the allowlist rule; the reader never runs elsewhere. Non-Apple hosts need the allowlist, or Allow every site with the sign_in every-site rules. Shared 3 per 10 min limit, code checked as 4-10 digits, never in a reply or log. no_code carries a Keytray hint; several_codes lists usernames only. CLI: verify-code [site] [username]. Docs and AGENTS.md updated.
Tested: pnpm typecheck green; unit.test.ts verify_code block (new cases for vault path, hint, several_codes, username, needs_user, http/local/blocked refusal, shared rate limit, bad code, no code in reply). Pre-existing on main and unrelated: one managed options-page unit failure; relay/wsl python tests fail locally because the installed helper holds the named pipe.
Closes #339