Repository navigation
Spike: can a non-browser client reach Apple's helper (#330) - #338
Conversation
Before: nothing showed what a process outside the browser needs to reach Apple's helper protocol. Now: scripts/spike/non-browser-client.ts pairs and looks up a login over the 4-byte framing against the fake helper.
Before: no written answer on whether a non-browser client can reach Apple's helper. Now: docs/desktop-app-spike.md has sourced findings, script output, verdicts, an owner checklist and a go or no-go; linked from docs/agent-protocol.md.
Before: four citations pointed a few lines off. Now: they point at the lines they name.
|
Check for PR #338
The script output is quoted in section 1 of the doc. Typecheck and test pass locally and CI is green. |
|
Diff review: PR #338 (head c563647), checked against the Plan, its amendment, the Plan review and the Check comment on #330. Read only. Protocol claims, spot-checked against src/apple/protocol.ts and vendor/au2001 (all hold):
Script safety:
Sensitive data: no local paths, personal data or mention of AI, agents-as-tools or assistants in the three changed files. The only login is the fake Deviations:
Everything else in the Plan and its amendment is met: Action.DELETE and FAILED_TO_DELETE are checked, a one-line verdict is given per edge case, the owner steps are a checklist, pins are present, the link is in docs/agent-protocol.md, and the script output is quoted. OK to merge: yes, after fixing deviation 1 in the doc (a wording change; none of the doc's claims are wrong). Item 2 can be fixed in the same edit. |
Before: the origin finding ignored the Windows probe, ADD_NEW was missing, and two cells misquoted their sources. Now: Windows hello is cited, macOS is named as the open part, and the table and cells match their sources.
|
Check for PR #338 (after the review fixes, commit 4b72323)
CI is green on 4b72323. |
|
Check: PR #338 at head 4b72323, against the Plan edge cases (#330 (comment))
|
|
Check: PR #338 at head 4b72323, one line per Plan edge case
|
|
Diff review: PR #338 (head 4b72323). Read only. I spot-checked the doc's cites against the head. protocol.ts:69-76, enums.ts:35-52, agent-protocol.md:50 and :105-111, and windows-findings.md:32 all say what the doc says. The script only uses the fake helper. I found no correctness, security or cost problems. Two minor points:
Nothing blocks merge. |
Findings only, nothing shipped. docs/desktop-app-spike.md has the sourced findings, a verdict per edge case, an owner-only checklist and a go or no-go. scripts/spike/non-browser-client.ts is a throwaway script that pairs and looks up a login against the fake helper (node scripts/spike/non-browser-client.ts).
Refs #330