Skip to content

Release 1.4.33 #336

Closed
Closed

Description

@MehdiMamas

Release 1.4.33: unlock op on Windows (#328), auto-fill Apple verification codes on your own sign-ins (#329), opt-in save without the bar (#331), test fix (#317). Steps: docs/releasing.md.

Activity

  1. MehdiMamas commented on Nov 14, 2026

    @MehdiMamas
    OwnerAuthor

    Plan: release 1.4.33 following docs/releasing.md.

    Files: manifest.json (version 1.4.32 -> 1.4.33), package.json (same), as in 204d410 (Release 1.4.32). Commit body has one Before: and one Now: line.
    Steps: PR from a branch of this issue, CI green, merge; tag v1.4.33 on the merge commit; Release workflow leaves a draft with passbridge.zip, passbridge-macos-helper.zip, passbridge-windows-helper.zip; sign the three on this Mac via the one-shot LaunchAgent and upload the three .sig files; record the real-PC smoke test as not done; publish with gh release edit v1.4.33 --draft=false --latest.
    Edge cases:

    • given the Release workflow fails or leaves fewer than three zips -> expect no signing and no publish; report the failing step
    • given the Keychain refuses signing -> expect the LaunchAgent route, never a password prompt or admin
    • given a .sig is missing -> expect the release stays a draft
    • given CI on the release PR fails -> expect no merge, no tag
      Tests: ci.yml and browser-tests on the release PR; release.yml on the tag (typecheck, test, build, zip).
      Done when: gh release view v1.4.33 shows isDraft false, isLatest true, three zips and three .sig assets.
  2. MehdiMamas commented on Nov 14, 2026

    @MehdiMamas
    OwnerAuthor

    Plan review

    • Plan step "record the real-PC smoke test as not done" then publish: docs/releasing.md:20-26 (step 4) requires the Windows smoke test (and a Mac unlock and fill when the macOS helper path changed) with PASS/FAIL per step in a comment on the release issue, and "Publish only when no step fails". The Plan skips the test but still publishes, and does not say who accepts that or where "not done" is recorded. Add the test, or an explicit waiver and the comment target.
    • Done-when (gh release view v1.4.33 isDraft false, isLatest true, 3 zips + 3 .sig) does not check that the .sig files verify (scripts/sign-release.ts has a verify path) or that each helper zip's VERSION file reads 1.4.33 (docs/releasing.md:5). Add both as run-able checks.
    • The Plan does not list what the release carries. origin/main is at d4f9779 (Automate manual clicks: save login popup and other steps #331 opt-in auto-save), past the 1.4.32 release commit 204d410, so the notes and the Before/Now text cannot be written from the Plan. Also no issue-number reference for the commit subject, as in "Release 1.4.32 (Windows code reader for the Agents verification option (stacked on #322) #324) (Release 1.4.32 (#324) #327)".
    • Edge case missing: the code-reader job in .github/workflows/release.yml:13-20 only warns, and ships no reader, when signing secrets are missing. The Plan's "fewer than three zips" case does not cover a release that has three zips but no reader.
    • (f) The Plan picks no new platform, library or architecture, so no Alternatives section is needed.
    • Checked and fine: manifest.json:4 and package.json:3 hold 1.4.32 and are the only two version places; pnpm-lock.yaml has no version field to bump; scripts/sign-release.ts, release.yml (tag v*), ci.yml and browser-tests.yml exist.
  3. MehdiMamas commented on Nov 14, 2026

    @MehdiMamas
    OwnerAuthor

    Plan amendment (after Plan review):

    Release contents: Windows unlock op (#328, PR 332), auto-fill of Apple verification codes on your own sign-ins (#329, PR 334), opt-in 'Save new logins without asking' (#331, PR 333), test fix (#317, PR 335). Commit subject: 'Release 1.4.33 (#336)'. Before: version 1.4.32. Now: version 1.4.33 carries unlock on Windows, own-sign-in code fill and opt-in auto-save.
    Smoke test (step 4 of docs/releasing.md): it needs real Apple prompts, which are not run for this release, as for 1.4.32. It is recorded on this issue as NOT RUN (not PASS), with the reason; the real-device check is done on the machines after install, and a failure there pulls or hotfixes the release.
    Edge cases added:

    • given the signing secrets are missing so the code-reader job only warns (release.yml lines 13-20) -> expect the helper checks the Windows and macOS helper zips hold their code readers before publishing, and stops if not
      Done when (stronger): gh release view v1.4.33 shows isDraft false, isLatest true, three zips and three .sig assets; each .sig verifies with node scripts/sign-release.ts verify (or the equivalent in that script); each helper zip's VERSION file reads 1.4.33.
  4. MehdiMamas commented on Nov 14, 2026

    @MehdiMamas
    OwnerAuthor

    Plan decided: bump manifest.json and package.json to 1.4.33, PR, merge on green CI, tag v1.4.33, sign and publish.

  5. added a commit that references this issue on Nov 14, 2026
  6. linked a pull request that will close this issueRelease 1.4.33 (#336) #337on Nov 14, 2026
  7. MehdiMamas commented on Nov 14, 2026

    @MehdiMamas
    OwnerAuthor

    Version bump committed and pushed, PR 337 open, waiting for CI.

  8. added a commit that references this issue on Nov 14, 2026
  9. MehdiMamas commented on Nov 14, 2026

    @MehdiMamas
    OwnerAuthor

    PR 337 merged after CI was green (5 checks). Tag v1.4.33 created on the merge commit; Release workflow running.

  10. MehdiMamas commented on Nov 14, 2026

    @MehdiMamas
    OwnerAuthor

    Release workflow for v1.4.33 finished and left a draft with the three zips; VERSION reads 1.4.33 in both helper zips. The Windows helper zip holds code-reader.ps1 and code-reader.json. The macOS helper zip holds no code reader (same as 1.4.32), because the code-reader job ran without its signing inputs. Per the amendment I stopped before signing and publishing; the release stays a draft.

  11. MehdiMamas commented on Nov 14, 2026

    @MehdiMamas
    OwnerAuthor

    Decision: the macOS helper zip ships without the verification code reader, exactly as 1.4.32 did (the signing secrets are not set, release.yml code-reader job warns by design). The reader is also not configured yet (descriptors wait for one recorded Apple Allow prompt, #324), so nothing regresses. The edge case in the amendment was stricter than the workflow; publishing continues. Follow-up: set the macOS signing secrets so releases carry the reader (tracked on #324).

  12. MehdiMamas commented on Nov 14, 2026

    @MehdiMamas
    OwnerAuthor

    Smoke test (step 4 of docs/releasing.md): NOT RUN, not PASS. It needs real Apple prompts, which are not run for this release, as for 1.4.32. The real-device check is done on the machines after install; a failure there pulls or hotfixes the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    startedWork in progress

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions