Repository navigation
Use neutral names in fixtures, mocks, tests and docs - #216
Conversation
Before: the mock data, activity tests and comments held real-looking logins, a group name and device names. Now: they use alice, bob, carol, alice-desktop and bobs-macbook.local; the tests keep the same assertions.
…README Before: relay fixtures used the maintainer login and the real private attachments repo name. Now: they use alice and owner/attachments-repo; the public repo links stay.
Before: gitleaks reported 5 hits, all fake values in tests. Now: .gitleaksignore lists their fingerprints and a scan finds no leaks.
Before: tests and docs held a real-looking login, group name, path and project folder name. Now: they use alice, Alice & friends, ana and webapp, with <owner>/claude-sync-data in the docs; expected strings changed with the inputs.
|
Check: PR 216 against the Plan edge cases (CI: 3 checks green; app/ui test 30 pass, relay test 138 pass, cargo tests ok, gitleaks clean with the ignore file)
|
|
Check: PR 216, all Plan cases including the Tests line
|
|
Check: PR 216 against the Plan edge cases (CI: 3 checks green; app/ui test 30 pass, relay test 138 pass, cargo tests ok, gitleaks clean with the ignore file)
|
|
Diff review: no problems found Checked against the Plan and its amendment on #200. All named files are covered, including the added ones: personal/tests.rs, service.rs:273, architecture.md, triage.test.ts and all of mock.ts. Input and expected strings changed together. A grep of the PR head for the old names finds only the kept items: LICENSE, Cargo.toml, tauri.conf.json, SECURITY.md, public-repo links and the bundle id. |
Replaces real-looking logins, a group name, device names, a path fixture and the private attachments repo name with neutral ones (alice, bob, carol, alice-desktop, bobs-macbook.local, Alice & friends, owner/attachments-repo, /claude-sync-data). Assertions keep their meaning; expected strings changed with their inputs. The sample commit text that named outside services is generic now. Adds .gitleaksignore with the 5 fake fixture fingerprints.
Kept on purpose: MehdiMamas/claude-sync links (releases, relay, update URL, feedback text, triage default), com.mehdimamas.claudesync, DEFAULT_REPO, LICENSE, Cargo.toml authors, tauri publisher, SECURITY.md.
Commands run:
Part of #200