Repository navigation
Stop ad blockers hiding the Adverts page (1.9.1) - #11
Merged
Merged
Conversation
…ng it (1.9.1) 1.9.0 called the panel `ad-panel` and its notes `ad-note`. EasyList, loaded by uBlock Origin and AdGuard by default, hides both by name, so the page arrived whole and the browser blanked it. Rename every class and id on the cuts pages to `cuts-*` / `ep-cuts*`, and add a test that fails if a name with ad, ads, advert, sponsor or promo as a word appears in a template, the stylesheet, the script or a rendered page. The test fails against v1.9.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Adverts page in 1.9.0 is blank for anyone running an ad blocker.
Cause. The panel was
#ad-panel/.ad-paneland its notes.ad-note. EasyList (default in uBlock Origin and AdGuard) has###ad-panel,##.ad-paneland##.ad-note, so the browser hid a page the server had sent complete.Fix. Every class and id on the cuts pages is renamed to
cuts-*/ep-cuts*. URLs and file names are unchanged.Guard.
test/integration/adblock-names.test.jsfails when a name with ad, ads, advert, sponsor or promo as a word appears in a template, app.css, app.js or a rendered page. It fails against v1.9.0.Tested
npm test: 1304 passed, 0 failed.🤖 Generated with Claude Code