Skip to content

Feature/honor enabled false - #12

Open
zhoulytwinyu wants to merge 2 commits into
Meemaw:masterfrom
zhoulytwinyu:feature/honor-enabled-false
Open

zhoulytwinyu wants to merge 2 commits into
Meemaw:masterfrom
zhoulytwinyu:feature/honor-enabled-false

Conversation

@zhoulytwinyu

Copy link
Copy Markdown

Hi Meemaw

This is a minor PR for sls-offline-schedule to honor the enabled=false attribute in scheduled events.

All it does is to filter out scheduled events that are enabled=false. When enabled=true, or when enabled is not defined, the events are scheduled as usual.

One unit test is updated and one is created, to test that when enabled=true, events are scheduled and when false, disabled.

This is tested with old versions of serverless and serverless-offline as well. Hope these does not affect this PR. I will be stuck with these antiquated packages for quite a while, sadly, sigh:
"serverless": "1.40.0",
"serverless-offline": "5.10.1",

Looking forward to your feedback.
Best
Joe

@hope-portal-services

Copy link
Copy Markdown

Any intention of merging this? This a pretty big issue to ignore.

@zhoulytwinyu

Copy link
Copy Markdown
Author

@hope-portal-services
Hi there, I have switched to serverless 2.x.x with serverless-offline-scheduler (with the 'r' at the end). It's a bit confusing when serverless.com says this repo is being maintained which serverless-offline-scheduler is not. I think it is the other way around.

There is no headache switching to the scheduler, but beware of the changes in serverless cli, and other dependencies.

@hope-portal-services

Copy link
Copy Markdown

@hope-portal-services
Hi there, I have switched to serverless 2.x.x with serverless-offline-scheduler (with the 'r' at the end). It's a bit confusing when serverless.com says this repo is being maintained which serverless-offline-scheduler is not. I think it is the other way around.

There is no headache switching to the scheduler, but beware of the changes in serverless cli, and other dependencies.

Oh great, that was easy. Thanks for the heads up.

@Meemaw Meemaw left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, if you rebase this PR we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants