You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a minor PR for sls-offline-schedule to honor the enabled=false attribute in scheduled events.
All it does is to filter out scheduled events that are enabled=false. When enabled=true, or when enabled is not defined, the events are scheduled as usual.
One unit test is updated and one is created, to test that when enabled=true, events are scheduled and when false, disabled.
This is tested with old versions of serverless and serverless-offline as well. Hope these does not affect this PR. I will be stuck with these antiquated packages for quite a while, sadly, sigh:
"serverless": "1.40.0",
"serverless-offline": "5.10.1",
@hope-portal-services
Hi there, I have switched to serverless 2.x.x with serverless-offline-scheduler (with the 'r' at the end). It's a bit confusing when serverless.com says this repo is being maintained which serverless-offline-scheduler is not. I think it is the other way around.
There is no headache switching to the scheduler, but beware of the changes in serverless cli, and other dependencies.
@hope-portal-services
Hi there, I have switched to serverless 2.x.x with serverless-offline-scheduler (with the 'r' at the end). It's a bit confusing when serverless.com says this repo is being maintained which serverless-offline-scheduler is not. I think it is the other way around.
There is no headache switching to the scheduler, but beware of the changes in serverless cli, and other dependencies.
The reason will be displayed to describe this comment to others. Learn more.
Hi, if you rebase this PR we can merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Meemaw
This is a minor PR for sls-offline-schedule to honor the enabled=false attribute in scheduled events.
All it does is to filter out scheduled events that are enabled=false. When enabled=true, or when enabled is not defined, the events are scheduled as usual.
One unit test is updated and one is created, to test that when enabled=true, events are scheduled and when false, disabled.
This is tested with old versions of serverless and serverless-offline as well. Hope these does not affect this PR. I will be stuck with these antiquated packages for quite a while, sadly, sigh:
"serverless": "1.40.0",
"serverless-offline": "5.10.1",
Looking forward to your feedback.
Best
Joe